On 13/12/2019 16:59, Jan Beulich wrote: > On 13.12.2019 16:49, Anthony PERARD wrote: >> On Fri, Dec 13, 2019 at 12:05:11PM +0100, Jan Beulich wrote: >>> On 12.12.2019 19:27, Anthony PERARD wrote: >>>> --- /dev/null >>>> +++ b/xen/.gitignore >>>> @@ -0,0 +1,2 @@ >>>> +*.lex.c >>>> +*.tab.[ch] >>> Why do these get moved here from ... >>> >>>> --- a/xen/tools/kconfig/.gitignore >>>> +++ b/xen/tools/kconfig/.gitignore >>>> @@ -1,12 +1,8 @@ >>>> # >>>> # Generated files >>>> # >>>> -config* >>>> -*.lex.c >>>> -*.tab.c >>>> -*.tab.h >>>> -zconf.hash.c >>>> *.moc >>>> +*conf-cfg >>> here? >> Well, it's more like they move from linux.git/scripts/kconfig/.gitignore >> to linux.git/.gitignore > Which doesn't answer the why (for our repo).
srsly? We shouldn't edit headers we don't actually resync because it may make resyncing harder (allegedly), yet we shouldn't keep an in-sync directory in sync when we do actually resync it? I find your lack of consistency in review requests impossible to predict. As far as I'm concerned, Anthony's patch is fine. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel