On 16/12/2019 11:47, Jan Beulich wrote: >> What >> you've done here is half-virtualise something we have no intention to >> ever virtualise for guests. >> >> Both of these should be blanket #GP faults. AMD should never be in the >> position of seeing amd_ppin clear but PPIN_CTL returning LOCKOUT, and >> while Intel does have model specific behaviour, whatever else might be >> behind that MSR obviously shouldn't be leaking though either. > In the interest of getting this ack-ed I might switch to the > blanket-#GP as you suggest, but I'm having trouble seeing why > giving back sane (and safe) values is wrong. This isn't meant > to indicate we might virtualize more of this. But why incur an > unnecessary #GP(0) in the guest when we can indicate the same > in a more "friendly" manner?
Why add dead code to Xen? It is unnecessary complexity in some already-complicated functions which are going to become far more complicated by the time we get Xen's MSR behaviour into a somewhat-reasonable state. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
