On 19/12/2019 11:45, Durrant, Paul wrote: >> -----Original Message----- >> From: Andrew Cooper <andrew.coop...@citrix.com> >> Sent: 19 December 2019 11:30 >> To: Durrant, Paul <pdurr...@amazon.com>; xen-devel@lists.xenproject.org >> Cc: Wei Liu <w...@xen.org>; Jan Beulich <jbeul...@suse.com>; Roger Pau Monné >> <roger....@citrix.com> >> Subject: Re: [Xen-devel] [PATCH] x86/save: reserve HVM save record numbers >> that have been consumed... >> >> On 19/12/2019 11:06, Durrant, Paul wrote: >>>> It is not fair or reasonable to include extra headroom in a "oh dear we >>>> screwed up - will the community be kind enough to help us work around >>>> our ABI problems" scenario. >>>> >>> I would have thought all the pain you went through to keep XenServer >> going with its non-upstreamed hypercall numbers would have made you a >> little more sympathetic to dealing with past mistakes. >> >> I could object to the principle of the patch, if you'd prefer :) >> >> If you recall for the legacy window PV driver ABI breakages, I didn't >> actually reserve any numbers upstream in the end. All compatibility was >> handled locally. > And I remember how nasty the hacks were ;-)
Like I'm ever going to forget those... For anyone else reading this thread and is a little confused, https://github.com/xenserver/xen.pg/blob/XS-7.1.x/master/xen-legacy-win-xenmapspace-quirks.patch ought to clear some things up. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
