> -----Original Message----- > From: Andrew Cooper <andrew.coop...@citrix.com> > Sent: 19 December 2019 12:16 > To: Durrant, Paul <pdurr...@amazon.com>; xen-devel@lists.xenproject.org > Cc: Wei Liu <w...@xen.org>; Jan Beulich <jbeul...@suse.com>; Roger Pau Monné > <roger....@citrix.com> > Subject: Re: [PATCH v2] x86/save: reserve HVM save record numbers that > have been consumed... > > On 19/12/2019 12:04, Paul Durrant wrote: > > ...for patches not (yet) upstream. > > > > This patch is simply adding a comment to reserve save record number > space > > to avoid the risk of clashes between existent downstream changes made by > > Amazon and future upstream changes which may be incompatible. > > > > Signed-off-by: Paul Durrant <pdurr...@amazon.com> > > Reviewed-by: Wei Liu <w...@xen.org> > > --- > > Cc: Jan Beulich <jbeul...@suse.com> > > Cc: Andrew Cooper <andrew.coop...@citrix.com> > > Cc: "Roger Pau Monné" <roger....@citrix.com> > > > > v2: > > - Reduce patch to just a comment > > --- > > xen/include/public/arch-x86/hvm/save.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/xen/include/public/arch-x86/hvm/save.h > b/xen/include/public/arch-x86/hvm/save.h > > index b2ad3fcd74..b3d445acf7 100644 > > --- a/xen/include/public/arch-x86/hvm/save.h > > +++ b/xen/include/public/arch-x86/hvm/save.h > > @@ -639,6 +639,8 @@ struct hvm_msr { > > > > #define CPU_MSR_CODE 20 > > > > +/* Range 22 - 40 reserved for Amazon */ > > What about 21 and 22? And where does the actual number stop, because > based on v1, its not 40. >
The range is inclusive (maybe that's not obvious?). For some reason 21 was skipped but why do you say the top is not 40? That was what I set HVM_SAVE_CODE_MAX to in v1. Paul _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel