On 20/12/2019 13:29, Jan Beulich wrote: > In 5655ce8b1ec2 ("x86/IRQ: make internally used IRQs also honor the > pending EOI stack") it was mentioned that both the check_eoi_deferral > per-CPU variable and the cpu_has_pending_apic_eoi() were added just to > have as little impact on existing behavior as possible, to reduce the > risk of a last minute regression in 4.13. > > Upon closer inspection, dropping the variable is an option only if all > callers of ->end() would assume the responsibility of also calling > flush_ready_eoi(). Therefore only drop the cpu_has_pending_apic_eoi() > guard now. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> > --- > TBD: In the end I'm not sure this is really worth it then.
The resulting logic is more simple, which is justification alone. Acked-by: Andrew Cooper <andrew.coop...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel