> -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: 16 January 2020 10:40 > To: Durrant, Paul <pdurr...@amazon.co.uk> > Cc: xen-devel@lists.xenproject.org; Ian Jackson > <ian.jack...@eu.citrix.com>; Wei Liu <w...@xen.org>; Anthony PERARD > <anthony.per...@citrix.com>; Andrew Cooper <andrew.coop...@citrix.com>; > George Dunlap <george.dun...@eu.citrix.com>; Julien Grall > <jul...@xen.org>; Konrad Rzeszutek Wilk <konrad.w...@oracle.com>; Stefano > Stabellini <sstabell...@kernel.org>; jandr...@gmail.com > Subject: Re: [PATCH v3 4/6] libxl: allow creation of domains with a > specified or random domid > > On 16.01.2020 10:36, Paul Durrant wrote: > > --- a/xen/include/public/xen.h > > +++ b/xen/include/public/xen.h > > @@ -614,6 +614,9 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); > > /* Idle domain. */ > > #define DOMID_IDLE xen_mk_uint(0x7FFF) > > > > +/* Mask for valid domain id values */ > > +#define DOMID_MASK 0x7FFF > > Seeing it used in context, any reason not to use xen_mk_uint() > here as well? >
I did wonder but I thought it best not to impose a type on a mask. Paul _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
