> -----Original Message----- > From: Xen-devel <xen-devel-boun...@lists.xenproject.org> On Behalf Of Jan > Beulich > Sent: 20 January 2020 09:51 > To: Sergey Dyasli <sergey.dya...@citrix.com> > Cc: Stefano Stabellini <sstabell...@kernel.org>; Julien Grall > <jul...@xen.org>; Wei Liu <w...@xen.org>; Konrad Rzeszutek Wilk > <konrad.w...@oracle.com>; George Dunlap <george.dun...@eu.citrix.com>; > Andrew Cooper <andrew.coop...@citrix.com>; Doug Goldstein > <car...@cardoe.com>; xen-de...@lists.xen.org; Daniel De Graaf > <dgde...@tycho.nsa.gov>; Ian Jackson <ian.jack...@eu.citrix.com> > Subject: Re: [Xen-devel] [PATCH v3 1/2] xsm: add config option for denied > string > > On 17.01.2020 17:44, Sergey Dyasli wrote: > > Signed-off-by: Sergey Dyasli <sergey.dya...@citrix.com> > > In principle > Acked-by: Jan Beulich <jbeul...@suse.com> > > But I think it would be nice to have a non-empty description, at > least to reason why the option addition is deemed useful. > > > --- a/xen/common/Kconfig > > +++ b/xen/common/Kconfig > > @@ -236,6 +236,14 @@ choice > > bool "SILO" if XSM_SILO > > endchoice > > > > +config XSM_DENIED_STRING > > + string "xen_version denied string" > > I guess inserting "hypercall" into this prompt would set better > context without needing to resort to the help text, i.e. > "xen_version hypercall denied string". Thoughts? >
"xen_version hypercall denied information replacement string"? It's not like the hypercall as a whole is being denied, after all. Paul > Jan > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xenproject.org > https://lists.xenproject.org/mailman/listinfo/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel