On 1/21/20 5:49 PM, Tamas K Lengyel wrote: > MEM_SHARING_DESTROY_GFN is used on the 'flags' bitfield during unsharing. > However, the bitfield is not used for anything else, so just convert it to a > bool instead. > > Signed-off-by: Tamas K Lengyel <tamas.leng...@intel.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com>
But is there a particular advantage to getting rid of the bitfield? You're the maintainer, so it's your decision of course. But if it were me I'd leave it as a bitfield so that all the bitfield code is there if it's needed in the future. Flipping it to a bool, with the risk of flipping it back to a bitfield later, seems like pointless churn to me. (Although perhaps the reason will become evident by the time I get to the end of the series.) -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
