> -----Original Message----- > From: Roger Pau Monné <roger....@citrix.com> > Sent: 12 February 2020 18:01 > To: Wei Liu <w...@xen.org> > Cc: Xen Development List <xen-devel@lists.xenproject.org>; Durrant, Paul > <pdurr...@amazon.co.uk>; Michael Kelley <mikel...@microsoft.com>; Wei Liu > <li...@microsoft.com>; Jan Beulich <jbeul...@suse.com>; Andrew Cooper > <andrew.coop...@citrix.com> > Subject: Re: [PATCH 2/4] x86/hypervisor: pass flags to > hypervisor_flush_tlb > > On Wed, Feb 12, 2020 at 04:09:16PM +0000, Wei Liu wrote: > > Hyper-V's L0 assisted flush has fine-grained control over what gets > > flushed. We need all the flags available to make the best decisions > > possible. > > > > No functional change because Xen's implementation doesn't care about > > what is passed to it. > > While it's certainly fine to pass a flags field with more information, > the flush flags for Xen can also contain FLUSH_CACHE, FLUSH_VCPU_STATE > or FLUSH_ROOT_PGTBL, can you add an assert that those never get passed > to the flush hook? > > IMO we should define a mask with FLUSH_TLB, FLUSH_TLB_GLOBAL, > FLUSH_VA_VALID and FLUSH_ORDER_MASK and assert that those are the only > valid flags to be used for the hypervisor assisted flush hook. >
Agreed that this should be abstracted; we certainly don't want to have various bits of Xen needing to know what hypervisor it is running on top of. Paul > Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
