On Fri, Feb 28, 2020 at 02:13:45PM +0100, Jan Beulich wrote: > On 28.02.2020 13:41, Roger Pau Monné wrote: > > On Fri, Feb 28, 2020 at 01:10:59PM +0100, Jan Beulich wrote: > >> We should neither cause IOMMU initialization as a whole to fail in this > >> case (we should still be able to bring up the system in non-x2APIC or > >> x2APIC physical mode), nor should the remainder of the function be > >> skipped (as the main part of it won't get entered a 2nd time) > > > > I'm not sure I see why it won't get entered a second time. AFAICT > > init_done won't be set if amd_iommu_init fails, and hence will be > > called again with xt == false in iov_detect? > > Not very far from the top of the function there is > > /* Have we been here before? */ > if ( ivrs_bdf_entries ) > return 0; > > Hence me saying "main part" rather than "the function as a whole".
Oh, yes, sorry. Reviewed-by: Roger Pau Monné <roger....@citrix.com> Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
