> -----Original Message----- > From: Tamas K Lengyel <ta...@tklengyel.com> > Sent: 28 February 2020 19:32 > To: Durrant, Paul <pdurr...@amazon.co.uk> > Cc: Xen-devel <xen-devel@lists.xenproject.org>; Jan Beulich > <jbeul...@suse.com>; Andrew Cooper <andrew.coop...@citrix.com>; Wei Liu > <w...@xen.org>; Roger Pau Monné <roger....@citrix.com>; George Dunlap > <george.dun...@citrix.com>; Ian Jackson <ian.jack...@eu.citrix.com>; > Julien Grall <jul...@xen.org>; Konrad Rzeszutek Wilk > <konrad.w...@oracle.com>; Stefano Stabellini <sstabell...@kernel.org>; Tim > Deegan <t...@xen.org> > Subject: Re: [PATCH 5/6] mm: add 'is_special_page' macro... > > > diff --git a/xen/arch/x86/mm/mem_sharing.c > b/xen/arch/x86/mm/mem_sharing.c > > index 3835bc928f..c14a724c6d 100644 > > --- a/xen/arch/x86/mm/mem_sharing.c > > +++ b/xen/arch/x86/mm/mem_sharing.c > > @@ -842,7 +842,7 @@ static int nominate_page(struct domain *d, gfn_t > gfn, > > > > /* Skip xen heap pages */ > > Perhaps adjust (or remove) the comment? >
Yes. The comment can just be dropped I think. Paul > > page = mfn_to_page(mfn); > > - if ( !page || is_xen_heap_page(page) ) > > + if ( !page || is_special_page(page) ) > > goto out; > > Thanks, > Tamas _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
