On 27.02.2020 14:09, Roger Pau Monné wrote: > On Wed, Feb 26, 2020 at 11:33:49AM +0000, Anthony PERARD wrote: >> @@ -161,29 +173,47 @@ else >> $(CC) $(c_flags) -c $< -o $@ >> endif >> >> -%.o: %.S Makefile >> - $(CC) $(a_flags) -c $< -o $@ >> +quiet_cmd_cc_o_S = CC $@ >> +cmd_cc_o_S = $(CC) $(a_flags) -c $< -o $@ >> + >> +%.o: %.S FORCE >> + $(call if_changed,cc_o_S) >> + >> + >> +quiet_cmd_obj_init_o = INIT_O $@ > > INIT_O seems kind of weird, maybe just using CHECK would be OK?
CHECK is not expressing what's going on - one could/would imply that the object file doesn't get changed at all, but its sections get renamed. I think INIT_O is sufficiently expressive at least to people knowing the build system. > The rest LGTM: > > Reviewed-by: Roger Pau Monné <roger....@citrix.com> Acked-by: Jan Beulich <jbeul...@suse.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
