On 10.03.2020 13:20, Paul Durrant wrote:
>> -----Original Message-----
>> From: Jan Beulich <jbeul...@suse.com>
>> Sent: 10 March 2020 11:02
>> To: p...@xen.org
>> Cc: xen-devel@lists.xenproject.org; 'Kevin Tian' <kevin.t...@intel.com>;
>> 'Stefano Stabellini'
>> <sstabell...@kernel.org>; 'Julien Grall' <jul...@xen.org>; 'Wei Liu'
>> <w...@xen.org>; 'Konrad Wilk'
>> <konrad.w...@oracle.com>; 'George Dunlap' <george.dun...@eu.citrix.com>;
>> 'Andrew Cooper'
>> <andrew.coop...@citrix.com>; 'Ian Jackson' <ian.jack...@citrix.com>
>> Subject: Re: [PATCH v2 2/5] IOMMU: iommu_intpost is x86/HVM-only
>>
>> On 10.03.2020 11:54, Paul Durrant wrote:
>>>> -----Original Message-----
>>>> From: Jan Beulich <jbeul...@suse.com>
>>>> Sent: 09 March 2020 10:43
>>>>
>>>> @@ -486,8 +480,10 @@ int __init iommu_setup(void)
>>>> panic("Couldn't enable %s and iommu=required/force\n",
>>>> !iommu_enabled ? "IOMMU" : "Interrupt Remapping");
>>>>
>>>> +#ifndef iommu_intpost
>>>> if ( !iommu_intremap )
>>>> iommu_intpost = 0;
>>>
>>> Nit: 0 -> false
>>
>> Hmm, I'm not touching this line, and the goal of the patch isn't
>> to (also) switch _all_ assignments to the variable.
>
> Yes, but it is in context and you normally ask for fix-ups where
> they are in context. In this case it’s a pretty trivial addition to the patch.
Hmm, I now notice that in another place I already do such an in-context
adjustment, so I'll do so here too. Normally I (try to) restrict such
(requests) to lines touched anyway.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
