On Wed, Apr 01, 2020 at 05:45:21PM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH] timeout: adjust timeout when running nested
> tests"):
> > sub target_adjust_timeout ($$) {
> > my ($ho,$timeoutref) = @_; # $ho might be a $gho
> > + my $nestinglvl = $ho->{NestingLevel} || $ho->{Host}{NestingLevel};
>
> I think this wannts to be // not ||. If you agree I will fix this up
> and commit.
Yes, I agree.
> Since what this does otherwise is to take all baremetal hosts and give
> them an empty Host hash due to autovivification.
>
> > + if ($nestinglvl) {
> > + $adjust->(1 << $nestinglvl, "nesting level");
> > + }
>
> I still think the use of << is very odd and I can't resist moaning
> about it. But you're the patch author so I will let you choose the
> style here.
Feel free to change to 2 ** $nestinglvl at commit, you are the
maintainer so it's important that you can read the code easily.
Thanks, Roger.
