On 24.04.2020 11:02, Julien Grall wrote: > On 17/04/2020 10:52, Hongyan Xia wrote: >> @@ -763,10 +763,10 @@ static void cleanup_frame_table(struct mem_hotadd_info >> *info) >> continue; >> } >> - ASSERT(l1e_get_flags(l2e_to_l1e(l2e)[l1_table_offset(sva)]) & >> - _PAGE_PRESENT); >> - sva = (sva & ~((1UL << PAGE_SHIFT) - 1)) + >> - (1UL << PAGE_SHIFT); >> + ASSERT(l1e_get_flags(l1e_from_l2e(l2e, l1_table_offset(sva))) & >> + _PAGE_PRESENT); >> + >> + sva = (sva & ~((1UL << PAGE_SHIFT) - 1)) + (1UL << PAGE_SHIFT); > > NIT: While you are modifying the indentation. Couldn't we use PAGE_MASK and > PAGE_SIZE here?
Oh, yes, this would be nice. Jan
