On Thu, May 14, 2020 at 12:25 PM Ian Jackson <ian.jack...@citrix.com> wrote: > > Jason Andryuk writes ("[PATCH v5 06/21] libxl: write qemu arguments into > separate xenstore keys"):
> > + xs_set_permissions(ctx->xsh, t, GCSPRINTF("%s/rtc/timeoffset", > > vm_path), roperm, ARRAY_SIZE(roperm)); > > This line seems out of place. At least, it is not mentioned in the > commit message. If it's needed, can you please split it out - and, of > course, then, provide an explanation :-). This was copied over from the mini-os version. It looks like it is unused by qemu-xen, so it can be dropped. Thanks, Jason