On Mon, May 18, 2020 at 03:15:17PM +0100, Ian Jackson wrote: > Jason Andryuk writes ("Re: [PATCH v5 09/21] libxl: add save/restore support > for qemu-xen in stubdomain"): > > On Thu, May 14, 2020 at 12:35 PM Ian Jackson <ian.jack...@citrix.com> wrote: > > > It's not stated anywhere here that I can see but I think what is > > > happening here is that your wrapper script knows the qemu savefile > > > pathname and reads it directly. Maybbe a comment would be > > > worthwhile ? > > > > The existing comment "Linux stubdomain connects specific FD to > > STUBDOM_CONSOLE_RESTORE" is trying to state that. > > STUBDOM_CONSOLE_RESTORE is defined as 2 for console 2 (/dev/hvc2), but > > it is only a libxl_internal.h define. > > Err, by "the qemu savefile pathname" I meant the pathname in dom0. > I assume your wrapper script opens that and feeds it to the console. > Is that right ?
Not really a wrapper script. On dom0 side it is console backend (qemu) instructed to connect the console to a file, instead of pty. I have implemented similar feature in my xenconsoled patch series sent a while ago (sent along with v2 of this series), but that series needs some more love. On the stubdomain side, it is a script that launches qemu - opens a /dev/hvc2, then pass the FD to qemu via -incoming option (which is really constructed by libxl). -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing?
signature.asc
Description: PGP signature