On Mon, Jul 13, 2020 at 02:22:12PM +0200, Saheed O. Bolarinwa wrote: > This goal of these series is to move the definition of *all* PCIBIOS* from > include/linux/pci.h to arch/x86 and limit their use within there. > All other tree specific definition will be left for intact. Maybe they can > be renamed.
More comments later, but a few trivial whitespace issues you can clean up in the meantime. Don't repost for at least a few days to avoid spamming everybody. I found these with: $ b4 am -om/ 20200713122247.10985-1-refactormys...@gmail.com $ git am m/20200713_refactormyself_move_all_pcibios_definitions_into_arch_x86.mbx Applying: atm: Change PCIBIOS_SUCCESSFUL to 0 .git/rebase-apply/patch:11: trailing whitespace. iadev = INPH_IA_DEV(dev); .git/rebase-apply/patch:12: trailing whitespace. for(i=0; i<64; i++) .git/rebase-apply/patch:13: trailing whitespace. if ((error = pci_read_config_dword(iadev->pci, .git/rebase-apply/patch:16: trailing whitespace, space before tab in indent. return error; .git/rebase-apply/patch:17: trailing whitespace. writel(0, iadev->reg+IPHASE5575_EXT_RESET); warning: squelched 5 whitespace errors warning: 10 lines add whitespace errors. Applying: atm: Tidy Success/Failure checks .git/rebase-apply/patch:13: trailing whitespace. .git/rebase-apply/patch:14: trailing whitespace. iadev = INPH_IA_DEV(dev); .git/rebase-apply/patch:15: trailing whitespace. for(i=0; i<64; i++) .git/rebase-apply/patch:21: trailing whitespace. writel(0, iadev->reg+IPHASE5575_EXT_RESET); .git/rebase-apply/patch:22: trailing whitespace. for(i=0; i<64; i++) warning: squelched 3 whitespace errors warning: 8 lines add whitespace errors. Applying: atm: Fix Style ERROR- assignment in if condition .git/rebase-apply/patch:12: trailing whitespace. unsigned int pci[64]; .git/rebase-apply/patch:13: trailing whitespace. .git/rebase-apply/patch:14: trailing whitespace. iadev = INPH_IA_DEV(dev); .git/rebase-apply/patch:23: trailing whitespace. writel(0, iadev->reg+IPHASE5575_EXT_RESET); .git/rebase-apply/patch:32: trailing whitespace. udelay(5); warning: squelched 2 whitespace errors warning: 7 lines add whitespace errors. Applying: PCI: Change PCIBIOS_SUCCESSFUL to 0 .git/rebase-apply/patch:37: trailing whitespace. struct pci_ops apecs_pci_ops = .git/rebase-apply/patch:50: trailing whitespace. static int .git/rebase-apply/patch:59: trailing whitespace. struct pci_ops cia_pci_ops = .git/rebase-apply/patch:94: trailing whitespace. static int .git/rebase-apply/patch:103: trailing whitespace. struct pci_ops lca_pci_ops = warning: squelched 10 whitespace errors warning: 15 lines add whitespace errors.