On 16.07.2020 13:41, Roger Pau Monné wrote: > On Wed, Jul 15, 2020 at 12:15:10PM +0200, Jan Beulich wrote: >> Use ENXIO instead of EINVAL to cover the two cases of the address not >> satisfying the requirements. This will make an issue here better stand >> out at the call site. > > Not sure whether I would use EFAULT instead of ENXIO, as the > description of it is 'bad address' which seems more inline with the > error that we are trying to report.
The address isn't bad in the sense of causing a fault, it's just that we elect to not allow it. Hence I don't think EFAULT is suitable. I'm open to replacement suggestions for ENXIO, though. >> Also add a missing compat-mode related size check: If the sizes >> differed, other code in the function would need changing. Accompany this >> by a change to the initial sizeof() expression, tying it to the type of >> the variable we're actually after (matching e.g. the alignof() added by >> XSA-327). >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > Reviewed-by: Roger Pau Monné <roger....@citrix.com> Thanks, Jan