> -----Original Message----- > From: Andrew Cooper <andrew.coop...@citrix.com> > Sent: 24 July 2020 19:39 > To: Paul Durrant <p...@xen.org>; xen-devel@lists.xenproject.org > Cc: Paul Durrant <pdurr...@amazon.com>; Kevin Tian <kevin.t...@intel.com>; > Jan Beulich > <jbeul...@suse.com> > Subject: Re: [PATCH 3/6] iommu: remove iommu_lookup_page() and the > lookup_page() method... > > On 24/07/2020 17:46, Paul Durrant wrote: > > From: Paul Durrant <pdurr...@amazon.com> > > > > ... from iommu_ops. > > > > This patch is essentially a reversion of dd93d54f "vtd: add lookup_page > > method > > to iommu_ops". The code was intended to be used by a patch that has long- > > since been abandoned. Therefore it is dead code and can be removed. > > And by this, you mean the work that you only partial unstreamed, with > the remainder of the feature still very much in use by XenServer? >
I thought we basically decided to bin the original PV IOMMU idea though? > Please don't go breaking in-use things, simply because we're fixing > Xen's IOMMU mess once large XSA at a time... > > As far as I can tell, this patch doesn't interact with any others in the > series. > I can leave it, but I still don't think anything other than current XenServer will ever use it... so it really ought to just be in the downstream patch queue IMO. Paul > ~Andrew
