On Mon, Aug 24, 2020 at 11:21:20AM +0100, Andrew Cooper wrote: > On 24/08/2020 09:00, Jürgen Groß wrote: > > On 24.08.20 09:51, Jan Beulich wrote: > >> On 24.08.2020 09:23, Jürgen Groß wrote: > >>> On 24.08.20 08:44, Jan Beulich wrote: > >>>> On 23.08.2020 07:52, Jürgen Groß wrote: > >>>>> On 23.08.20 07:24, osstest service owner wrote: > >>>>>> flight 152672 linux-linus real [real] > >>>>>> http://logs.test-lab.xenproject.org/osstest/logs/152672/ > >>>>>> > >>>>>> Regressions :-( > >>>>> > >>>>> With 32-bit pv support now removed from the kernel the associated > >>>>> tests > >>>>> should be removed for the upstream kernel, too. > >>>> > >>>> Not exactly sure how things are organized, but isn't the 2nd > >>>> <arch> in the test identifier currently specifying "Dom0 > >>>> bitness" as a whole? If so, shouldn't testing a 32-bit tool > >>>> stack build continue to be done (under this same name perhaps), > >>>> just with a 64-bit kernel now? In which case the next question > >>> > >>> Only the linux-linus tests are affected right now. "Old" kernels can > >>> still be used for 32-bit tests. And PVH ones, of course. > >>> > >>>> is whether the 64-bit kernel is actually fully ready to be used > >>>> this way. I'm afraid it isn't, as there's still no privcmd > >>>> compat ioctl handling afaict, which I would say should have > >>>> been a prereq for removing PV support from 32-bit kernels. > >>> > >>> No, I don't think so. > >>> > >>> 32-bit pv linux kernels are missing Meltdown mitigation and using a > >>> 32-bit toolstack on a 64-bit kernel is no feature I'd like to > >>> encourage. > >> > >> Where else do you propose to test the 32-bit tool stack then? > > > > Right now stable kernels, later PVH only. > > > >> Even if right now only linux-linus is really affected, sooner > >> or later the stable Linux tree will also be switched to one > >> which doesn't have 32-bit PV support anymore. > > > > Yes. > > > >> I also have trouble seeing why it should be use to dictate what > >> bitness a user space people are running. Even more so that we've > > > > We are not talking about some random user programs, but the tools > > we are providing and which are running in dom0 only. > > > > And I don't think running a 32-bit toolstack on a 64-bit kernel is > > supported right now (in case it is, then we don't need to worry as > > it should continue to work). I don't think we should start supporting > > that just for being able to test it. > > 32bit toolstack on a 64bit kernel doesn't remotely work, due to pointers > embedded in structures which privcmd passes through unmodified. > > It will actually start working again after the tools ABI stability work, > because this is just one of the many ABI mistakes which will be corrected. > > > That said, 32bit toolstacks are not a useful or sensible thing these > days. I strongly suspect it gets 0 use outside of OSSTest.
We still have the armhf tests on osstest, so a 32bit toolstack is still getting exercised (albeit not exactly the same code paths as x86-32). Right now the PVH dom0 tests are amd64 only, but I could add a 32bit one if that's found to be useful. FWIW, on FreeBSD PVH is only implemented for amd64 (and so is dom0). IIRC at some point we figured out that no one was using the 32bit images provided for AWS so while there's still support for FreeBSD running on Xen in 32bit mode I don't think anyone uses it (the more that I tend to find 32bit specific issues whenever I test the images myself, that no one seems to care about). Roger.
