On 04/09/2020 09:33, Jan Beulich wrote:
> On 01.09.2020 04:50, Igor Druzhinin wrote:
>> Guest kernel does need to know in some cases where the tables are located
>> to treat these regions properly. One example is kexec process where
>> the first kernel needs to pass firmware region locations to the second
>> kernel which is now a requirement after 02a3e3cdb7f12 ("x86/boot: Parse SRAT
>> table and count immovable memory regions").
>
> I'm still struggling with the connection here: Reserved regions
> surely are "immovable" too, aren't they?
"Immovable" regions here are RAM that doesn't go away by hot-unplug. That change
was necessary in Linux to avoid image randomized placement to these regions.
> Where's the connection to
> the E820 map in the first place - the change cited above is entirely
> about SRAT? And I can't imagine kexec getting away with passing on
> ACPI NVS regions, but not reserved ones.
>
They got away with it for as long as kexec exists I think. The point was that
those reserved regions were not accessed during early boot as long as kexec
kernel stays
at transition tables. Now ACPI portion of it is accessed which highlighted our
imprecise reporting of memory layout to the guest - which I think should be
fixed
either way.
I'm not going to argue if reserved regions should be mapped to transition
tables or
not - I don't think it's important in context related to this patch. There were
already several kernel releases without that mappings and those also should be
able
to invoke kdump.
Igor
