On Tuesday, September 15, 2020 12:36 PM, Jan Beulich <jbeul...@suse.com> wrote: > In order for these casts to be halfway safe, they need to happen in > inline functions, not macros. That way it'll be sufficiently clear > and certain that it's really only the const which gets changed, > but not e.g. also the pointed-to type.
At some point it really looks easier to just add const to the efi headers rather than having to recreate all of their verbose APIs. The efiapi.h header was added nine years ago and has been edited once, seven years ago, so it isn't a source of significant churn. Meanwhile, if someone wants to delve into the cursed mines of sourceforge, perhaps the gnuefi devs can be convinced to update their sources. > Apart from this I think the whole change wants splitting up, to > (about) one basic change at a time. Yeah, the string and file const changes ended up mixed in the change set. They are sort of related, but it would be easiest if the EFI constness was fixed first so that the printed strings don't need additional casts. -- Trammell
