On 11.11.2020 15:51, Dario Faggioli wrote: > On Mon, 2020-10-26 at 10:13 +0100, Juergen Gross wrote: >> Add /cpupool/<cpupool-id> directories to hypfs. Those are completely >> dynamic, so the related hypfs access functions need to be >> implemented. >> >> Signed-off-by: Juergen Gross <jgr...@suse.com> >> > So, I'm almost sold... Just one comment: > >> --- a/xen/common/sched/cpupool.c >> +++ b/xen/common/sched/cpupool.c >> @@ -999,6 +1073,10 @@ static int __init cpupool_init(void) >> >> cpupool_gran_init(); >> >> +#ifdef CONFIG_HYPFS >> + hypfs_add_dir(&hypfs_root, &cpupool_dir, true); >> +#endif >> + > What would you think about doing this in an helper function > (hypfs_cpupool_init() ?), implemented inside the above #ifdef and as an > empty stub if !CONFIG_HYPFS ? > > That will save us from having the #ifdef-s again here.
Having a hypfs_add_dir() stub would also allow to achieve this, and then, going forward, perhaps also elsewhere. Jan
