On 24.11.2020 01:58, Andrew Cooper wrote: > On 23/10/2020 11:17, Jan Beulich wrote: >> ... into its own CU, to build it into an archive. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> >> --- >> xen/common/lib.c | 39 ---------------------------------- >> xen/lib/Makefile | 1 + >> xen/lib/parse-size.c | 50 ++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 51 insertions(+), 39 deletions(-) >> create mode 100644 xen/lib/parse-size.c > > What is the point of turning this into a library? It isn't a leaf > function (calls simple_strtoull()) and doesn't have any any plausible > way of losing all its callers in various configurations (given its > direct use by the cmdline parsing logic).
It's still a library function. As said earlier, I think _all_ of what's now in lib.c should move to lib/. That's how it should have been from the beginning, or stuff shouldn't have been put in lib.c. The one alternative I see is to move the code next to parse_bool() / parse_boolean(), in kernel.c, or put all parse_*() into a new common/parse.c. Jan
