On 1/22/21 4:56 AM, Julien Grall wrote: > Hi Boris, > > On 20/01/2021 22:49, Boris Ostrovsky wrote: >> diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c >> index 19168572fd3e..1f2abf6679d7 100644 >> --- a/tools/libs/light/libxl_dom.c >> +++ b/tools/libs/light/libxl_dom.c >> @@ -383,9 +383,10 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid, >> /* Construct a CPUID policy, but only for brand new domains. Domains >> * being migrated-in/restored have CPUID handled during the >> * static_data_done() callback. */ >> - if (!state->restore) >> + if (!state->restore) { >> libxl__cpuid_legacy(ctx, domid, false, info); >> - >> + libxl__msr_policy(ctx, domid, info); > > AFAICT, this is going to break compilation of the toolst on Arm because > libxl__msr_policy(). Yes, it will ;-( > > However, I am a bit unsure whether we should define a stub for this on Arm. > It feels to me it would be better to pass an extra boolean (restore) to > libxl__arch_domain_create() and directly implement it there. Yes. And move libxl__cpuid_legacy call there too then. -boris
- Re: [PATCH v2 1/4] xl: Add support for ignore_msrs o... Roger Pau Monné
- Re: [PATCH v2 1/4] xl: Add support for ignore_ms... Jan Beulich
- Re: [PATCH v2 1/4] xl: Add support for ignor... Roger Pau Monné
- Re: [PATCH v2 1/4] xl: Add support for i... Jan Beulich
- Re: [PATCH v2 1/4] xl: Add support ... Boris Ostrovsky
- Re: [PATCH v2 1/4] xl: Add supp... Roger Pau Monné
- Re: [PATCH v2 1/4] xl: Add supp... Jan Beulich
- [PATCH v2 4/4] tools/libs: Apply MSR policy to a guest Boris Ostrovsky
- Re: [PATCH v2 4/4] tools/libs: Apply MSR policy to a... Wei Liu
- Re: [PATCH v2 4/4] tools/libs: Apply MSR policy to a... Julien Grall
- Re: [PATCH v2 4/4] tools/libs: Apply MSR policy ... Boris Ostrovsky
- Re: [PATCH v2 4/4] tools/libs: Apply MSR policy to a... Roger Pau Monné
- Re: [PATCH v2 4/4] tools/libs: Apply MSR policy ... Boris Ostrovsky
- [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED Boris Ostrovsky
- Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED Jan Beulich
- Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED Boris Ostrovsky
- Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED Boris Ostrovsky
- Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED Roger Pau Monné
- Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED Boris Ostrovsky
- Re: [PATCH v2 2/4] x86: Introduce MSR_UNHAND... Roger Pau Monné
- Re: [PATCH v2 2/4] x86: Introduce MSR_UN... Boris Ostrovsky