On 08/10/2020 19:57, Paul Durrant wrote: > diff --git a/xen/include/public/save.h b/xen/include/public/save.h > index c4be9f570c..bccbaadd0b 100644 > --- a/xen/include/public/save.h > +++ b/xen/include/public/save.h > @@ -58,6 +59,16 @@ struct domain_context_start { > uint32_t xen_major, xen_minor; > }; > > +struct domain_context_shared_info { > + uint32_t flags; > + > +#define _DOMAIN_CONTEXT_32BIT_SHARED_INFO 0 > +#define DOMAIN_CONTEXT_32BIT_SHARED_INFO \ > + (1U << _DOMAIN_CONTEXT_32BIT_SHARED_INFO)
There is no need for the logarithm version of this constant. You do however want an explicit uint32_t _rsvd; so buffer[] doesn't start at the wrong alignment for an efficient memcpy() in 64bit builds of Xen. ~Andrew