On Mon, 25 Jan 2021, Bertrand Marquis wrote: > Hi Stefano, > > > On 23 Jan 2021, at 02:19, Stefano Stabellini <sstabell...@kernel.org> wrote: > > > > A recent thread [1] has exposed a couple of issues with our current way > > of handling EXPERT. > > > > 1) It is not obvious that "Configure standard Xen features (expert > > users)" is actually the famous EXPERT we keep talking about on xen-devel > > > > 2) It is not obvious when we need to enable EXPERT to get a specific > > feature > > > > In particular if you want to enable ACPI support so that you can boot > > Xen on an ACPI platform, you have to enable EXPERT first. But searching > > through the kconfig menu it is really not clear (type '/' and "ACPI"): > > nothing in the description tells you that you need to enable EXPERT to > > get the option. > > > > So this patch makes things easier by doing two things: > > > > - introduce a new kconfig option UNSUPPORTED which is clearly to enable > > UNSUPPORTED features as defined by SUPPORT.md > > That’s a great change which will improve user experience.
Thank you! > > - change EXPERT options to UNSUPPORTED where it makes sense: keep > > depending on EXPERT for features made for experts > > > > - tag unsupported features by adding (UNSUPPORTED) to the one-line > > description > > > > Shouldn’t we add (EXPERT) for expert options in the same way for coherency ? I take you mean add "(EXPERT)" to the one-line description in kconfig. I am OK with that, probably better as a second separate patch. I'll add it.