On Sat, Jan 30, 2021 at 12:50:13PM +0100, Manuel Bouyer wrote: > On Thu, Jan 28, 2021 at 12:08:02PM +0100, Roger Pau Monné wrote: > > [...] > > Also, the qemu-ifup script doesn't seem to be part of the NetBSD > > scripts that are upstream, is this something carried by the NetBSD > > package? > > Actually, the script is part of qemu-xen-traditional: > tools/qemu-xen-traditional/i386-dm/qemu-ifup-NetBSD > > and it's installed as part of 'make install'. The same script can be used > for both qemu-xen-traditional and qemu-xen as long as we support only > bridged mode by default. > > qemu-xen-traditional did call the script with the bridge name. > This patch makes qemu-xen call the script with the same parameters, > and add the XEN_DOMAIN_ID environnement variable. > > Is it OK to keep the script from qemu-xen-traditional (and installed as > part of qemu-xen-traditional) for now ?
I think you want to move the script into hotplug/NetBSD/ because it should be possible to install a system without qemu-xen-traditional (--disable-qemu-traditional) and only qemu-upstream, and the script will still be needed in that case. Thanks, Roger.
