On 04/03/2021 13:03, Andrew Cooper wrote: > This is inappropriate for the header file of a standalone library with stable > API and ABI. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Ian Jackson <i...@xenproject.org> > CC: Wei Liu <w...@xen.org> > > Discovered when trying to actually remove the use of unstable libraries from a > trivial userspace emulator. Current users of xendevicemodel.h inherit > __XEN_TOOLS__ from libxenctrl.h (or equiv). > ---
... and this patch is broken. But CI doesn't pick it up because we've also broken the header check scripts as part of library refactoring. The 4.13 header checks do work, and point out that there is yet another set of bogus __XEN_TOOLS__ ifdef in the Xen public ABI, which hides the ioserverid_t type and (rightly) breaks the build. Which in turn proves that the header checks (for xendevicemodel.h at least) never ever checked anything originally, because they didn't pass __XEN_TOOLS__ in at the top and just saw an empty file. ~Andrew
