Hi Ian, On 05/03/2021 13:58, Ian Jackson wrote:
Julien Grall writes ("Re: [PATCH for-4.15 2/2] tools/xenstore: Check the format printf for xprintf() and barf{,_perror}()"):Urgh, you are right. Actually, the extern was added recently by Anthony:dacdbf7088d6a3705a9831e73991c2b14c519a65 ("tools/xenstore: mark variable in header as extern") I completely forgot it despite I needed to backport the patch to our downstream Xen.How horrible. Maybe we could add a comment to the code, next to the declaration, about this crazy situation.
Would the following comment work for you? /* Function pointer as xprintf() can be configured at runtime. */ I can fold it in my patch while committing. Cheers,
Ian.
-- Julien Grall
