Hi Roger,

On 06/04/2021 08:24, Roger Pau Monné wrote:
On Mon, Apr 05, 2021 at 04:57:02PM +0100, Julien Grall wrote:
From: Julien Grall <jgr...@amazon.com>

The function sh_audit_flags() is returning pointer to literal strings.
They should not be modified, so the return is now const and this is
propagated to the callers.

Take the opportunity to fix the coding style in the declaration of
sh_audit_flags.

Signed-off-by: Julien Grall <jgr...@amazon.com>

While doing the cleanup I think you could narrow the scope of the 's'
variables also, but doesn't need to be part of this patch:

I think you are right. I will look at it as a follow-up.

Reviewed-by: Roger Pau Monné <roger....@citrix.com>

Thanks for the review!

Cheers,

--
Julien Grall

Reply via email to