On 11/05/2021 19:05, Edwin Török wrote: > diff --git a/tools/ocaml/libs/mmap/xenmmap.ml > b/tools/ocaml/libs/mmap/xenmmap.ml > index af258942a0..e17a62e607 100644 > --- a/tools/ocaml/libs/mmap/xenmmap.ml > +++ b/tools/ocaml/libs/mmap/xenmmap.ml > @@ -24,11 +24,6 @@ type mmap_map_flag = SHARED | PRIVATE > (* mmap: fd -> prot_flag -> map_flag -> length -> offset -> interface *) > external mmap': Unix.file_descr -> mmap_prot_flag -> mmap_map_flag > -> int -> int -> mmap_interface = "stub_mmap_init" > -(* read: interface -> start -> length -> data *) > -external read: mmap_interface -> int -> int -> string = "stub_mmap_read" > -(* write: interface -> data -> start -> length -> unit *) > -external write: mmap_interface -> string -> int -> int -> unit = > "stub_mmap_write" > -(* getpagesize: unit -> size of page *) > external unmap': mmap_interface -> unit = "stub_mmap_final" > (* getpagesize: unit -> size of page *) > let make ?(unmap=unmap') interface = interface, unmap
Are comments supposed to be above or below the declaration? The double getpagesize and missing unmap comment looks like a copy&paste mistake in the past. ~Andrew
