> On 16 Jun 2021, at 15:43, Julien Grall <jul...@xen.org> wrote: > > From: Julien Grall <jgr...@amazon.com> > > xenstored_core.h will consider live-udpate is not supported if > O_CLOEXEC doesn't exist. However, the header doesn't include the one > defining O_CLOEXEC (i.e. fcntl.h). This means that depending on > the header included, some source file will think Live-Update is not > supported. > > I am not aware of any issue with the existing. Therefore this is just > a latent bug so far. > > Prevent any potential issue by including fcntl.h in xenstored_core.h > > Fixes: cd831ee438 ("tools/xenstore: handle CLOEXEC flag for local files and > pipes") > Signed-off-by: Julien Grall <jgr...@amazon.com> Reviewed-by: Luca Fancellu <luca.fance...@arm.com> > --- > tools/xenstore/xenstored_core.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h > index 34839b34f6e9..dac517156993 100644 > --- a/tools/xenstore/xenstored_core.h > +++ b/tools/xenstore/xenstored_core.h > @@ -24,6 +24,7 @@ > > #include <sys/types.h> > #include <dirent.h> > +#include <fcntl.h> > #include <stdbool.h> > #include <stdint.h> > #include <errno.h> > -- > 2.17.1 > >
- Re: [PATCH 03/10] tools/xenstore: Don't assume conn->... Juergen Gross
- Re: [PATCH 03/10] tools/xenstore: Don't assume conn... Juergen Gross
- Re: [PATCH 03/10] tools/xenstore: Don't assume ... Luca Fancellu
- Re: [PATCH 03/10] tools/xenstore: Don't ass... Juergen Gross
- [PATCH 01/10] MAINTAINERS: Add myself as reviewers for tools... Julien Grall
- [PATCH 06/10] tools/xenstored: Introduce a wrapper for conn-... Julien Grall
- Re: [PATCH 06/10] tools/xenstored: Introduce a wrapper ... Luca Fancellu
- Re: [PATCH 06/10] tools/xenstored: Introduce a wrapper ... Juergen Gross
- [PATCH 05/10] tools/xenstored: xenstored_core.h should inclu... Julien Grall
- Re: [PATCH 05/10] tools/xenstored: xenstored_core.h sho... Luca Fancellu
- Re: [PATCH 05/10] tools/xenstored: xenstored_core.h sho... Juergen Gross
- [PATCH 08/10] tools/xenstored: Extend restore code to handle... Julien Grall
- Re: [PATCH 08/10] tools/xenstored: Extend restore code ... Luca Fancellu
- Re: [PATCH 08/10] tools/xenstored: Extend restore code ... Juergen Gross
- Re: [PATCH 08/10] tools/xenstored: Extend restore c... Julien Grall
- Re: [PATCH 08/10] tools/xenstored: Extend resto... Juergen Gross
- [PATCH 07/10] tools/xenstored: delay_request: don't assume c... Julien Grall
- Re: [PATCH 07/10] tools/xenstored: delay_request: don't... Luca Fancellu
- Re: [PATCH 07/10] tools/xenstored: delay_request: don't... Juergen Gross