To me, it's more meaningful to change mmzone.h, because we're in xen world. Due to historical reason, still some of linux files are remained unchanged in xen/ia64, with most stuff useless (like MMZONE below). It's only work around in early stage for compilation, and now time for us to remove most of them and create new header files specific to xen/ia64 if necessary. I think this can be the guideline when you're cleaning up with confliction seen. ;-)
Thanks, Kevin >-----Original Message----- >From: [EMAIL PROTECTED] >[mailto:[EMAIL PROTECTED] On Behalf Of Masaki Kanno >Sent: 2006年2月27日 12:35 >To: [EMAIL PROTECTED]; [email protected] >Subject: [Xen-devel] [PATCH] Clean up warning for page_alloc.c > >Hi all, > >I clean up warning in xen/ia64. >The "MAX_ORDER" is redefined as I show below it. >I didn't change the Linux original code "mmzone.h" and thought >to change a local definition in "page_alloc.c". >This patch changes a local definition from "MAX_ORDER" to >"XEN_MAX_ORDER". > >page_alloc.c:222:1: warning: "MAX_ORDER" redefined >In file included from >/home/kanno/xen-ia64-unstable.hg/xen/include/asm-ia64/linux-xen/linux/gfp.h: >7, > from >/home/kanno/xen-ia64-unstable.hg/xen/include/asm/mm.h:6, > from >/home/kanno/xen-ia64-unstable.hg/xen/include/linux/mm.h:79, > from >/home/kanno/xen-ia64-unstable.hg/xen/include/asm-ia64/linux-xen/asm/uacc >ess.h:39, > from >/home/kanno/xen-ia64-unstable.hg/xen/include/asm/domain.h:143, > from >/home/kanno/xen-ia64-unstable.hg/xen/include/xen/sched.h:15, > from page_alloc.c:28: >/home/kanno/xen-ia64-unstable.hg/xen/include/asm-ia64/linux/mmzone.h:19: >1: warning: this is the location of the previous >definition > >Signed-off-by: Masaki Kanno <[EMAIL PROTECTED]> > >Best regards, > Kan _______________________________________________ Xen-ia64-devel mailing list [email protected] http://lists.xensource.com/xen-ia64-devel
