This one is for your comments. I also clean up some redundant spaces. For XENVER_UUID_LEN, I temp define it in xc_ia64_hvm_build.c and it would be removed when IA32 standardize on the marco.
>-----Original Message----- >From: Alex Williamson [mailto:[EMAIL PROTECTED] >Sent: 2007年8月23日 21:56 >To: Zhang, Xing Z >Cc: xen-ia64-devel >Subject: Re: [Xen-ia64-devel][PATCH] SMBios table support in XEN > >On Thu, 2007-08-23 at 19:00 +0800, Zhang, Xing Z wrote: >> Hi Alex: >> This patch used to get XEN version info and pass to GFW throuhg >> Hob. I tested it with other pathes which for GFW, OSI interface works >> fine with linux kernel 2.6.22.3. > >Hi, > > Two comments. First, check your indenting, it looks like you've got >tab indenting additions to space indented files in a few places. >Second, defining and using XENVER_UUID_LEN looks like a separate patch >that should be sent to xen-devel. I don't see why there would be any >problem getting it in, but we can just as easily use 16 until we >standardize on the macro. Thanks, > > Alex > >-- >Alex Williamson HP Open Source & Linux Org. >
smbios_for_xen_new.patch
Description: smbios_for_xen_new.patch
_______________________________________________ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel
