Hi, >On Sat, Apr 05, 2008 at 04:33:12PM +0200, [EMAIL PROTECTED] wrote: >> Selon Isaku Yamahata <[EMAIL PROTECTED]>: >> >> > diff -r bb2f8ba47833 include/asm-ia64/xen/privop.h >> > --- a/include/asm-ia64/xen/privop.h Tue Mar 25 12:37:54 2008 -0600 >> > +++ b/include/asm-ia64/xen/privop.h Sat Apr 05 07:27:30 2008 +0900 >> > @@ -67,7 +67,7 @@ >> > #endif >> > >> > #ifndef __ASSEMBLY__ >> > -#define XEN_HYPER_SSM_I asm("break %0" : : "i" (HYPERPRIVOP_SSM_I)) >> > +#define XEN_HYPER_SSM_I asm("break %0" : : "i" (HYPERPRIVOP_SSM_I): >> > "memory") >> > #define XEN_HYPER_GET_IVR asm("break %0" : : "i" (HYPERPRIVOP_GET_IVR)) >> > >> > /************************************************/ >> > >> > Shouldn't those be asm volatile, but asm? >> >> IIRC, according to the gcc doc asm without outputs are volatile. > >Ah, right. From gcc info. >> Assembler Instructions with C Expression Operands >> An `asm' instruction without any output operands will be treated >> identically to a volatile `asm' instruction. Thank you for your comments. I also think it's right. And I found XEN_HYPER_GET_IVR is wrong because it doesn't have return value. But it is not used, so I just remove it. I updated my patch.
Signed-off-by: Akio Takebe <[EMAIL PROTECTED]> Best Regards, Akio Takebe
inline_asm_barrier.3.patch
Description: Binary data
_______________________________________________ Xen-ia64-devel mailing list Xen-ia64-devel@lists.xensource.com http://lists.xensource.com/xen-ia64-devel