In timeout case events_r is don't care. When using pSOS skin in user space, __ev_receive() in syscall.c copy events_r to user space only when ev_receive was successful. But this comply with pSOS manual: "If successful, ev_receive() returns the actual events captured by the call in the location pointed to by events_r."
Philippe Gerum
<[EMAIL PROTECTED] An: Markus
Osterried <[EMAIL PROTECTED]>
g> Kopie:
xenomai-core@gna.org
Gesendet von: Blindkopie:
Philippe Gerum Thema: Re:
[Xenomai-core] Found bug in pSOS ev_receive()
<philippe.gerum
@gmail.com>
07.02.2007
12:15
Bitte antworten
an rpm
On Wed, 2007-02-07 at 11:57 +0100, Philippe Gerum wrote:
> On Wed, 2007-02-07 at 11:36 +0100, Markus Osterried wrote:
> > Hello,
> >
> > in pSOS skin function ev_receive() in file event.c I've found a bug.
> > When ev_receive() is called with EV_WAIT and an event is received, the
> > task is unblocked and everything is okay, then in this case the copy of
the
> > actual received events into *events_r is missing.
>
> Confirmed and fixed, thanks.
>
> --- ksrc/skins/psos+/event.c (revision 2108)
> +++ ksrc/skins/psos+/event.c (working copy)
> @@ -79,9 +79,10 @@
>
> if (xnthread_test_info(&task->threadbase, XNBREAK))
> err = -EINTR;
> - else if (xnthread_test_info(&task->threadbase, XNTIMEO)) {
> + else {
> *events_r = task->waitargs.evgroup.events;
> - err = ERR_TIMEOUT;
> + if (xnthread_test_info(&task->threadbase,
XNTIMEO))
> + err = ERR_TIMEOUT;
> }
>
> unlock_and_exit:
>
Actually, there was a second bug hiding in the timeout case, where the
copy back value was wrong, we should have returned the current state of
the event flag group and we returned the pended event mask instead. The
following patch against 2.3.0 fixes both issues.
--- ksrc/skins/psos+/event.c (revision 2134)
+++ ksrc/skins/psos+/event.c (working copy)
@@ -80,9 +80,10 @@
if (xnthread_test_info(&task->threadbase, XNBREAK))
err = -EINTR;
else if (xnthread_test_info(&task->threadbase, XNTIMEO)) {
+ err = ERR_TIMEOUT;
+ *events_r = evgroup->events;
+ } else
*events_r = task->waitargs.evgroup.events;
- err = ERR_TIMEOUT;
- }
unlock_and_exit:
--
Philippe.
_______________________________________________
Xenomai-core mailing list
Xenomai-core@gna.org
https://mail.gna.org/listinfo/xenomai-core
