On 2012-01-25 17:47, Jan Kiszka wrote: > On 2012-01-25 17:35, Gilles Chanteperdrix wrote: >> On 01/25/2012 05:21 PM, Jan Kiszka wrote: >>> We had two regressions in this code recently. So test all 6 possible >>> SIGDEBUG reasons, or 5 if the watchdog is not available. >> >> Ok for this test, with a few remarks: >> - this is a regression test, so should go to >> src/testsuite/regression(/native), and should be added to the >> xeno-regression-test > > What are unit test for (as they are defined here)? Looks a bit inconsistent. > >> - we already have a regression test for the watchdog called mayday.c, >> which tests the second watchdog action, please merge mayday.c with >> sigdebug.c (mayday.c also allows checking the disassembly of the code in >> the mayday page, a nice feature) > > It seems to have failed in that important last discipline. Need to check > why.
Because it didn't check the page content for correctness. But that's now done via the new watchdog test. I can keep the debug output, but the watchdog test of mayday looks obsolete to me. Am I missing something? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux _______________________________________________ Xenomai-core mailing list [email protected] https://mail.gna.org/listinfo/xenomai-core
