> > @@ -139,11 +139,11 @@ static int do_ioctl(int fd, unsigned int
> > request, void *arg) COBALT_IMPL(int, fcntl, (int fd, int cmd, ...))
> > {
> > va_list ap;
> > - int arg;
> > + void *arg;
> > int ret;
> >
> > va_start(ap, cmd);
> > - arg = va_arg(ap, int);
> > + arg = va_arg(ap, void *);
> > va_end(ap);
> >
> > ret = XENOMAI_SYSCALL3(sc_cobalt_fcntl, fd, cmd, arg); diff
> > --git a/lib/cobalt/wrappers.c b/lib/cobalt/wrappers.c index
> > 20ad63a61..2540e3c50 100644
> > --- a/lib/cobalt/wrappers.c
> > +++ b/lib/cobalt/wrappers.c
> > @@ -216,10 +216,10 @@ __weak
> > int __real_fcntl(int fd, int cmd, ...) {
> > va_list ap;
> > - int arg;
> > + void *arg;
> >
> > va_start(ap, cmd);
> > - arg = va_arg(ap, int);
> > + arg = va_arg(ap, void *);
> > va_end(ap);
> >
> > return fcntl(fd, cmd, arg);
> >
>
> Fair enough, however a generic 'long' may be a better pick than an
> opaque pointer type in this case (*), then you would need to fix up the
> Cobalt kernel side implementing the actual syscall to reflect this change.
Some fcntl calls use a pointer-to-struct, so void* or uintptr_t seems fitting
for this?
(TBH I just looked at what glibc is doing, and some weird archs might have
sizeof(long) < sizeof(void*))
If Xenomai only supports calls with an int, maybe truncate it just for the
syscall?
ret = XENOMAI_SYSCALL3(sc_cobalt_fcntl, fd, cmd, (int)arg);
(rest of the patch untouched)
Not sure how syscalls are done, I expected the arguments are just passed in
registers,
In which case it does not matter (unless you don’t fit a pointer in a register)
> Moving away from 'int' to a longer type will also require to make
> Cobalt's fcntl() syscall implementation aware of the mixed ABI models
> when CONFIG_XENO_ARCH_SYS3264 is enabled. i.e. the argument would
> still
> be conveyed as a 32bit value for applications conforming to the ia32emu
> or x32 ABIs running over a 64bit kernel.
Ok, I haven't thought about that at all. But since you apparently don't expect
a pointer now,
truncating the value to an int for the syscall seems fitting.
Norbert
________________________________
This message and any attachments are solely for the use of the intended
recipients. They may contain privileged and/or confidential information or
other information protected from disclosure. If you are not an intended
recipient, you are hereby notified that you received this email in error and
that any review, dissemination, distribution or copying of this email and any
attachment is strictly prohibited. If you have received this email in error,
please contact the sender and delete the message and any attachment from your
system.
ANDRITZ HYDRO GmbH
Rechtsform/ Legal form: Gesellschaft mit beschränkter Haftung / Corporation
Firmensitz/ Registered seat: Wien
Firmenbuchgericht/ Court of registry: Handelsgericht Wien
Firmenbuchnummer/ Company registration: FN 61833 g
DVR: 0605077
UID-Nr.: ATU14756806
Thank You
________________________________
_______________________________________________
Xenomai mailing list
Xenomai@xenomai.org
https://xenomai.org/mailman/listinfo/xenomai
