On 11/20/18 4:49 PM, Jan Kiszka wrote: > On 20.11.18 16:44, Philippe Gerum wrote: >> On 10/10/18 5:23 PM, Jan Kiszka wrote: >>> Drop the obsoleted mknod calls - all modern systems use devtmpfs, and >>> that creates the rtp nodes for us. >>> >>> Furthermore, switch the remaining installation of udev rules to proper >>> automake, using sysconfdir, INSTALL_DATA etc., dropping sudo from those >>> steps (installation into privileged folders implies "sudo make install" >>> or running as root in the first place). >>> >>> Finally, only differentiate between pre-existing udev.rules and default >>> installation into rules.d. >>> >>> This removes the need for the install-user target - drop it. >>> >> >> It looks like this one broke buildroot, which expects install-user. A >> compat one-liner like below may help in preventing a regression: >> >> diff --git a/Makefile.am b/Makefile.am >> index ef78bee89..20610ef2b 100644 >> --- a/Makefile.am >> +++ b/Makefile.am >> @@ -49,4 +49,6 @@ endif >> >> install-exec-local: udev-rules >> >> +install-user: udev-rules >> + >> .PHONY: FORCE >> > > Why not > > install-user: install > > ?
Yes, even better. -- Philippe.
