On Mon, Oct 26, 2020 at 09:20:20AM +0100, Jan Kiszka wrote:
> On 26.10.20 09:12, Fino Meng wrote:
> > On Mon, Oct 26, 2020 at 08:35:10AM +0100, Jan Kiszka wrote:
> >> On 23.10.20 11:04, Fino Meng wrote:
> >>> be aware of RTNET and RTIPC part still have compile error, I didn't
> >>> enable them in .config yet. hope can fix them next week.
> >>
> >> Do you have patches for RTnet and Analogy already? RTIPC is fixed in
> >> next. I'm currently trying to get CI fully running.
> >>
> >> Jan
> >
> > this morning, I didn't meet error when compile RTnet as module, strange.
>
> Just fixing that, linux/pci-aspm.h
>
> > for Analogy I didn't try yet, will try it today.
> >
> > Happy to know RTIPC is done, I was checking it's code and make it pass
> > compile like this:
> >
> > diff --git a/kernel/drivers/ipc/bufp.c b/kernel/drivers/ipc/bufp.c
> > index 45c917eb0..024f8f2f1 100644
> > --- a/kernel/drivers/ipc/bufp.c
> > +++ b/kernel/drivers/ipc/bufp.c
> > @@ -830,14 +830,16 @@ static int __bufp_setsockopt(struct bufp_socket *sk,
> > if (sopt.level == SOL_SOCKET) {
> > switch (sopt.optname) {
> >
> > - case SO_RCVTIMEO:
> > + case SO_RCVTIMEO_OLD:
> > + case SO_RCVTIMEO_NEW:
>
> *_NEW looks incorrect at this stage, see next.
>
> > ret = rtipc_get_timeval(fd, &tv, sopt.optval,
> > sopt.optlen);
> > if (ret)
> > return ret;
> > sk->rx_timeout = rtipc_timeval_to_ns(&tv);
> > break;
> >
> > - case SO_SNDTIMEO:
> > + case SO_SNDTIMEO_OLD:
> > + case SO_SNDTIMEO_NEW:
> > ret = rtipc_get_timeval(fd, &tv, sopt.optval,
> > sopt.optlen);
> > if (ret)
> > return ret;
> > @@ -922,14 +924,16 @@ static int __bufp_getsockopt(struct bufp_socket *sk,
> > if (sopt.level == SOL_SOCKET) {
> > switch (sopt.optname) {
> >
> > - case SO_RCVTIMEO:
> > + case SO_RCVTIMEO_OLD:
> > + case SO_RCVTIMEO_NEW:
> > rtipc_ns_to_timeval(&tv, sk->rx_timeout);
> > ret = rtipc_put_timeval(fd, sopt.optval, &tv, len);
> > if (ret)
> > return ret;
> > break;
> >
> > - case SO_SNDTIMEO:
> > + case SO_SNDTIMEO_OLD:
> > + case SO_SNDTIMEO_NEW:
> > rtipc_ns_to_timeval(&tv, sk->tx_timeout);
> > ret = rtipc_put_timeval(fd, sopt.optval, &tv, len);
> > if (ret)
> > diff --git a/kernel/drivers/ipc/iddp.c b/kernel/drivers/ipc/iddp.c
> > index 2a80eba65..c926b32ac 100644
> > --- a/kernel/drivers/ipc/iddp.c
> > +++ b/kernel/drivers/ipc/iddp.c
> > @@ -712,14 +712,16 @@ static int __iddp_setsockopt(struct iddp_socket *sk,
> > if (sopt.level == SOL_SOCKET) {
> > switch (sopt.optname) {
> >
> > - case SO_RCVTIMEO:
> > + case SO_RCVTIMEO_OLD:
> > + case SO_RCVTIMEO_NEW:
> > ret = rtipc_get_timeval(fd, &tv, sopt.optval,
> > sopt.optlen);
> >
> >
> > I also tested hackbench:
> >
> > while true ; do sudo taskset -c 1 hackbench -s 512 -l 200 -g 20 -f 50 -P ;
> > done
> >
> > it output errors, but the board is still alive.
> >
>
> Will check. Was that with my FPU fixes in place already?
>
> Jan
yes, without the FPU fixes, the board will hang after trigger
hackbench.
BR fino
>
> --
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux
