On 17.11.21 09:33, Chen, Hongzhan wrote: > Hi Jan > > Internally , we try to do some basic validation for linux_dovetail branch. > One of test is to > pass build after make allyesconfig. But it would fail because of enabled > CONFIG_XENO_TODO. > There is still something NTD in > include/cobalt/kernel/dovetail/pipeline/trace.h and > include/cobalt/kernel/dovetail/pipeline/clock.h related to this config. I am > tying to > look into TODO in include/cobalt/kernel/dovetail/pipeline/clock.h but I do > not know how to fix > TODO in include/cobalt/kernel/dovetail/pipeline/trace.h. Could you suggest > something about > fixing them? >
Oh, we missed some conversions... Some of the features in trace.h are unportable because ftrace does not provide equivalent functionality to the ipipe tracer (namely double buffering so that you can continue to record in flight-recorder mode while a previous recording remains available). We should likely return -ENOSYS then. xntrace_user_stop is widely similar to xntrace_user_freeze, namely trace_cobalt_trigger("user-freeze"), and that could be improved. For 3.3, dropping the related syscall is the better way - unless it still contains something that ftrace APIs do not provide AND that can be mapped on a kernel service. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux