On 30.11.21 08:31, Hongzhan Chen via Xenomai wrote:
> For dovetail-based, handle_oob_trap_entry would try to demote oob
> stage and leave in-band to do panic thing when fault happen.
>
> Signed-off-by: Hongzhan Chen <hongzhan.c...@intel.com>
>
> diff --git a/include/cobalt/kernel/dovetail/pipeline/trace.h
> b/include/cobalt/kernel/dovetail/pipeline/trace.h
> index 7147ab183..306dd549a 100644
> --- a/include/cobalt/kernel/dovetail/pipeline/trace.h
> +++ b/include/cobalt/kernel/dovetail/pipeline/trace.h
> @@ -91,18 +91,6 @@ static inline int xntrace_tick(unsigned long delay_ticks)
> /* ns */
> return 0;
> }
>
> -static inline int xntrace_panic_freeze(void)
> -{
> - TODO();
> - return 0;
> -}
> -
> -static inline int xntrace_panic_dump(void)
> -{
> - TODO();
> - return 0;
> -}
> -
> static inline bool xntrace_enabled(void)
> {
> return IS_ENABLED(CONFIG_DOVETAIL_TRACE);
> diff --git a/kernel/cobalt/dovetail/kevents.c
> b/kernel/cobalt/dovetail/kevents.c
> index 648929756..4da4f51b7 100644
> --- a/kernel/cobalt/dovetail/kevents.c
> +++ b/kernel/cobalt/dovetail/kevents.c
> @@ -64,14 +64,12 @@ void handle_oob_trap_entry(unsigned int trapnr, struct
> pt_regs *regs)
> */
> #if defined(CONFIG_XENO_OPT_DEBUG_COBALT) ||
> defined(CONFIG_XENO_OPT_DEBUG_USER)
> if (!user_mode(regs)) {
> - xntrace_panic_freeze();
> printk(XENO_WARNING
> "switching %s to secondary mode after exception #%u in "
> "kernel-space at 0x%lx (pid %d)\n", thread->name,
> trapnr,
> xnarch_fault_pc(regs),
> xnthread_host_pid(thread));
> - xntrace_panic_dump();
> } else if (xnarch_fault_notify(trapnr)) /* Don't report debug traps */
> printk(XENO_WARNING
> "switching %s to secondary mode after exception #%u from
> "
>
thanks, both applied.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
