On 01.03.22 08:51, Chen, Hongzhan wrote: > > >> -----Original Message----- >> From: Jan Kiszka <[email protected]> >> Sent: Tuesday, March 1, 2022 3:40 PM >> To: Chen, Hongzhan <[email protected]>; [email protected] >> Subject: Re: [PATCH 2/4] Kernel-shark: Add xenomai_cobalt_switch_events >> plugin for kernel-shark >> >> On 28.02.22 06:40, Hongzhan Chen wrote: >>> For Xenomai-cobalt enabled system, cobalt_switch_context means >>> that there is schedule and context switch in companion core(realtime >>> core), which we may need to do special treatment and take correct >>> action as main kernel sched_switch to visualize out-of-band state >>> of realtime tasks running in cobalt core. To achive our target, >>> we implement following: >>> >>> 1. store corresponding cobalt_switch_context events into >>> container data. >>> 2. modify pid stored in entry to be equal to next_pid to >>> show correct color in cpu bar when cobalt_switch_context >>> event happen. >>> 3. show blue hollow box to mark out-of-band state according to >>> cobalt_switch_context events. >>> 4. clickable cobalt_switch_context plugin shapes. >>> >>> Signed-off-by: Hongzhan Chen <[email protected]> >>> --- >>> kernel-shark/Makefile.am | 6 + >>> .../kernelshark/CobaltSwitchEvents.cpp | 156 ++++++++++++++++ >>> kernel-shark/kernelshark/Makefile.am | 18 ++ >>> kernel-shark/kernelshark/README | 75 ++++++++ >>> .../xenomai_cobalt_switch_events.c | 174 ++++++++++++++++++ >>> .../xenomai_cobalt_switch_events.h | 58 ++++++ >>> 6 files changed, 487 insertions(+) >>> create mode 100644 kernel-shark/Makefile.am >>> create mode 100644 kernel-shark/kernelshark/CobaltSwitchEvents.cpp >>> create mode 100644 kernel-shark/kernelshark/Makefile.am >>> create mode 100644 kernel-shark/kernelshark/README >>> create mode 100644 kernel-shark/kernelshark/xenomai_cobalt_switch_events.c >>> create mode 100644 kernel-shark/kernelshark/xenomai_cobalt_switch_events.h >>> >> >> ... >> >>> diff --git a/kernel-shark/kernelshark/README >>> b/kernel-shark/kernelshark/README >>> new file mode 100644 >>> index 000000000..41a26a39a >>> --- /dev/null >>> +++ b/kernel-shark/kernelshark/README >>> @@ -0,0 +1,75 @@ >>> + >>> +What is it? >>> +============= >>> + >>> + It is Xenomai plugin for kernel-shark to visualize out-of-band state >>> + of realtime thread running in companion core with making use of >>> + cobalt_switch_context events in trace log. >>> + >>> + For more introductions about kernel-shark , please refer to [1]. >>> + >> >> I think it's "KernelShark". Please check and then use that spelling >> consistently if I'm right. > > Actually, in kernelshark project , they are mixing using them. > > For example, like following commit message. There are lots of commit > messages include such name kernel-shark. > Or their repo name > https://git.kernel.org/pub/scm/utils/trace-cmd/kernel-shark.git > > commit 59b5763c7c52b703e3b8e05be801f7c85365c9d3 > Author: Yordan Karadzhov (VMware) <[email protected]> > Date: Wed Jan 19 14:02:28 2022 +0200 > > kernel-shark: Add KsPluginsGUI.hpp/.cpp > > Here we will place all GUI-related APIs that will be exposed to > the external plugins. For the moment we add only two such APIs > that will allow the plugins to manipulate the markers. > > Signed-off-by: Yordan Karadzhov (VMware) <[email protected]> >
Right, but website and README use "KernelShark". Maybe ask for clarification. Jan -- Siemens AG, Technology Competence Center Embedded Linux
