On 03.03.22 07:48, Chen, Hongzhan wrote: > > >> -----Original Message----- >> From: Jan Kiszka <jan.kis...@siemens.com> >> Sent: Thursday, March 3, 2022 2:39 PM >> To: Chen, Hongzhan <hongzhan.c...@intel.com>; xenomai@xenomai.org >> Subject: Re: [PATCH v2 2/3] Add --with-kernelshark option >> >> On 03.03.22 07:30, Chen, Hongzhan wrote: >>> >>> >>> >>>>> + tracing/Makefile \ >>>>> + tracing/kernelshark/Makefile \ >>>>> lib/Makefile \ >>>>> lib/boilerplate/Makefile \ >>>>> lib/boilerplate/init/Makefile \ >>>>> diff --git a/tracing/Makefile.am b/tracing/Makefile.am >>>>> index 8bdf1f906..7925ae9c6 100644 >>>>> --- a/tracing/Makefile.am >>>>> +++ b/tracing/Makefile.am >>>>> @@ -1,6 +1,7 @@ >>>>> - >>>>> +if BUILD_KERNELSHARK >>>>> SUBDIRS = \ >>>>> kernelshark >>>>> +endif >>>>> >>>>> DIST_SUBDIRS = \ >>>>> kernelshark >>>> >>>> Seems you lost the AC_PROG_CXX - things do not build now. >>> >>> Sorry, I assumed that patch [1] pass review , so I have not committed again >>> to review. >>> Could you apply this patch? >>> >>> https://xenomai.org/pipermail/xenomai/2022-February/047262.html >>> >> >> When sending v4 after my review remarks, please include all patches. > > If it already pass review , why cannot we merge it at first? >
It belongs logically to the kernelshark/libtraceevent series and is not needed otherwise. Jan -- Siemens AG, Technology Competence Center Embedded Linux
