Petr,

    Your patch to Base64 has been checked in and is available in the latest
nightly build,
please double check. there is one minor change to your patch, the
XMLPlatformUtils::fgTransService->isSpace() is used instead of the isspace()
(the one
from ctype.h).

    Do you consider to propose a similar patch ( adding encode()) to HexBin ?
thanks.

Rgds,

PeiYong Zhang


Petr Gotthard wrote:

> Hello world,
>
> please find attached patches for Base64 class, that provides
> several improvements.
>
> The main change is new method "Base64::encode" for encoding
> binary data and some new private data members.
> In coherence with these changes, it was necessary to rename some
> existing private data members and some variables, because their
> original names can lead to misunderstanding.
> Due to new data members, initialization method "Base64::init() was
> also "a little bit" improved.
>
> Moreover, in the method "Base64::decode" was the call of
> "XMLString::trim()" replaced by other code. Method "trim()"
> removes only leading and trailing whitespaces, but according to
> RFC 2045 was necessary to remove _all_ whitespaces from the string.
>
> I would be glad, if you apply these patches to an original code.
>
> Regards,
>
> Petr
>
>   ------------------------------------------------------------------------
>                        Name: Base64.cpp.patch
>    Base64.cpp.patch    Type: unspecified type (application/octet-stream)
>                    Encoding: base64
>
>                        Name: Base64.hpp.patch
>    Base64.hpp.patch    Type: unspecified type (application/octet-stream)
>                    Encoding: base64
>
>   ------------------------------------------------------------------------
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to