Edward, I think it doesn't hurt to apply your patch. So I am going to commit it then. BTW your patch also apply to src/runConfigure and tests/runConfigure, besides samples/runConfigure, right?
Thanks! Tinny Edward Avis wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > I sent in a small patch to fix argument parsing in > samples/runConfigure, which could get stuck in an infinite loop. > Tinny Ng suggested that runConfigure uses getopt(1) which should catch > invalid arguments by itself. > > For whatever reason, getopt didn't catch the invalid argument on my > system (SuSE Linux 7.2). I'm sorry, I don't remember what the flag was > but I do know that the runConfigure script sat there in an infinite loop > and it took a while to figure out and fix the problem. In other words > the patch I sent is a fix for a real bug I encountered. > > I think the problem may be that the getopt specification at the top gets > out of sync with the $1-processing loop. When this happens the loop can > get stuck. It would be a good idea to fix the getopt statement at the > top, but you should also fix the shell loop. That way when the two > lists of possible flags get out of sync again, there will be a clear > error message rather than just hanging. > > (Please cc me on replies since I do not read this list.) > > - -- > Ed Avis <[EMAIL PROTECTED]> > Finger for PGP key > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.0.6 (GNU/Linux) > Comment: For info see http://www.gnupg.org > > iD8DBQE8DkgqIMp73jhGogoRApqSAJ9N++wWipwD/gmUMJ9kDCcS+KKktgCbBLXL > fM/JfjZIzdgJopA24uXcT3g= > =OyOT > -----END PGP SIGNATURE----- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
