Hi Michael,
<sigh> Thanks for pointing this out. I'm less certain that this isn't
relevant; the original code was quite explicit about nulling the DOMString
stored in value.str, and that's why I (tried to) take pains to keep doing
so.
But at worst this will cause a small memory leak; it's better than a
segmentation fault. :)
Unless something else really horrible rears its head in the next few hours,
this won't make it into 2.3.0; but it will certainly make it into CVS
straightway.
Thanks for the patch!
Cheers,
Neil
Neil Graham
XML Parser Development
IBM Toronto Lab
Phone: 905-413-3519, T/L 969-3519
E-mail: [EMAIL PROTECTED]
|---------+------------------------------->
| | Michael Rafael |
| | Glavassevich |
| | <[EMAIL PROTECTED]|
| | aterloo.ca> |
| | |
| | 05/27/2003 12:05 PM |
| | Please respond to |
| | xerces-c-dev |
| | |
|---------+------------------------------->
>---------------------------------------------------------------------------------------------------------------------------------------------|
|
|
| To: [EMAIL PROTECTED]
|
| cc:
|
| Subject: [PATCH]: Small typo in dom/deprecated/AttrImpl
|
|
|
|
|
>---------------------------------------------------------------------------------------------------------------------------------------------|
Hi everyone,
I noticed a small typo in AttrImpl ('==' instead of '='). It shouldn't
make a difference behaviourly because it looks like DOMString's destructor
reduces the ref count of fHandle if not done explicitly.
Index: xml-xerces/c/src/xercesc/dom/deprecated/AttrImpl.cpp
===================================================================
RCS file:
/home/cvspublic/xml-xerces/c/src/xercesc/dom/deprecated/AttrImpl.cpp,v
retrieving revision 1.7
diff -u -r1.7 AttrImpl.cpp
--- xml-xerces/c/src/xercesc/dom/deprecated/AttrImpl.cpp 27 May
2003 03:51:07 -0000 1.7
+++ xml-xerces/c/src/xercesc/dom/deprecated/AttrImpl.cpp 27 May
2003 15:30:32 -0000
@@ -132,7 +132,7 @@
{
if(value.str != null)
{
- *(value.str) == null;
+ *(value.str) = null;
delete value.str;
value.str = null;
}
@@ -161,7 +161,7 @@
// DOMString* and setting the value field to null
if(value.str != null)
{
- *(value.str) == null;
+ *(value.str) = null;
delete value.str;
value.str = null;
}
-----------------------------------------
Michael Glavassevich
[EMAIL PROTECTED]
Candidate for Bachelor of Applied Science
Computer Engineering
University of Waterloo
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
