DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26980>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26980

XMLStringPool is not useful as a base class

           Summary: XMLStringPool is not useful as a base class
           Product: Xerces-C++
           Version: Nightly build (please specify the date)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Other
         Component: Utilities
        AssignedTo: [EMAIL PROTECTED]
        ReportedBy: [EMAIL PROTECTED]


XMLStringPool is used in the interface of multiple abstract base classes in 
Xerces-C.  However, it is a concrete class, which is a very bad design.

Even more, it is not amenable to derivation, since none of its data members 
are protected (except, strangely, its fCurId member).  Anyone wishing to 
implement their own string pool must provide their own implementation, but 
still have the baggage of the base class implementation.

My suggestion would be to make XMLStringPool and abstract base class, call the 
current class XMLStringPoolImpl, and make all of its data members protected.  
That would give implementors the best of both possible worlds.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to